-
Notifications
You must be signed in to change notification settings - Fork 26
Pixel Size Attributes #1157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pixel Size Attributes #1157
Conversation
|
At this point I will move onto trying to have |
|
Some more work done here. Added After thinking about some options for dealing with filters, it seems like the only tricky case was Still need to add some more tests. |
|
Confirmed the pixel_size is being picked up in ChimeraX when saved from ASPIRE. |
j-c-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Just a few things.
j-c-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
janden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for tracking down the pixel_sizes wherever they've managed to hide themselves. Just a few questions here.
|
Rebased to resolve minor downsample merge ocnflicts. |
Closes #1152 .
Adds pixel_size attribute to Volume and tests saving/loading default and non-default values.
Adds pixel_size attribute to Image and tests saving/loading default and non-default values.
Tests downsampling with default and non-default values.
Partially refactors Image tests to actually use fixtures (faster) and scopes them.