Skip to content

New Line Class with Back Project Method #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 139 commits into from
Closed

New Line Class with Back Project Method #1163

wants to merge 139 commits into from

Conversation

@certifiedp
Copy link
Collaborator

@certifiedp certifiedp commented Aug 2, 2024

Changes Include

  • creating a Line class (closely similar to that of the Image class but with different attributes)
  • creating a back_project method which takes a line class instance and turns it into an image with a number of angles
  • allowed users to run on or off the gpu
  • created tests for the new methods + class

garrettwrong and others added 30 commits July 12, 2024 11:22
@garrettwrong
10081 pipeline doc and sym updates
778d777
@garrettwrong
CL sync c3c4 eps change, and numerical issue
eaa9437
@garrettwrong
fix doc " typo
92b2e93
@garrettwrong
Log a diagnostic whether we are actually boosting anything
01058cc
@j-c-c @garrettwrong
symmetry_group pass-through for ClassAvgSource.
db84487
@j-c-c @garrettwrong
Add symmetry_group to test_indexed_source.
2511f43
@garrettwrong
missing f in log message
2b63e39
@garrettwrong
use utest_tolerance for single precision run to run variability
e92971e
@certifiedp
added 2D projection stub
6e45cfc
@certifiedp
initial test file add
5ac3cbc
@certifiedp
Stashing initial project with test placeholder
fa5f37b
@certifiedp
Style Updates
f6834b2
@certifiedp
Pytest fixtures
aef4619
@certifiedp
Cleanup
df8953d
@certifiedp
changed nufft call
9970e81
@garrettwrong @certifiedp
added stub for image stack line project
eafe89e 
marc to continue
@certifiedp
Dimensional Test Fix
c078f84
@certifiedp
Multidim FFT
49ecd4b
@certifiedp
Integrated stack reshape to project
399be2f
@certifiedp
Fleshed out Image Project Single and Multidim Tests
7994ecd
@certifiedp
Fixed the grid issues yay
59e4b24
@certifiedp
Angle slow moving axis
5532c3b
@certifiedp
Replaced FFT with rfft
6620a2e
@certifiedp
Cleaned up other unit tests
223065f
@certifiedp
Added Doc Test and Cleaned up Code
cff9378
@garrettwrong @certifiedp
fixup sinogram tests and simpler multi test
5192d54 
Co-authored-by: Marc Karimi <mk3652@decaf.math.princeton.edu.private>
@garrettwrong @certifiedp
fix irfft and shift
b321364 
Co-authored-by: Marc Karimi <mk3652@decaf.math.princeton.edu.private>
@certifiedp
added angles but need to change multidim
3d9d123
@certifiedp
Added Changes from PR: parameterized angles, adjusted tests according…
d486dd2 
…ly, renamed variables
@certifiedp
Added extra comments + Integrated Changes from lineproject_dbg2 branch
614f08d
j-c-c and others added 28 commits July 23, 2024 14:47
@j-c-c
remove scipy bump
6d18cec
@j-c-c
Revert scipy workaround.
5aeca45
@j-c-c
xfail ArrayFilter test for singles.
598d440
@j-c-c
make xfail strict
440cda2
@j-c-c
remove strict param
4be9032
@j-c-c
Use pytest fixtures.
4ecf092
@j-c-c
remove unused import
2368196
@garrettwrong
minimal patch to support cupy install and disabled cufinufft
3ae167f
@garrettwrong
skip enormous FFB2D test on GPU
57d34e0
@garrettwrong
simpler solution
325b1de
@garrettwrong
make the long workflow not so long
ff06daa
@garrettwrong
run long workflow on pull requests
7ae2f27
Added backproject script and stub in the image folder
a1c0727
Added One-Dimension Test for Backproject
4ddbe8c
Stashing
40d594c
Fixed Scaling Issue with BackProject and Integrated NRMSE to One Stac…
17b09dc 
…k Test
fixed single back_project test
d1c7fad
@garrettwrong
reorg Line to avoid circ import. Interop Image/Line classes
9d6c2f8
@garrettwrong
adjust tests towards Line/Image interop
5d5f9b7 
[skip ci]

Co-authored-by: Marc Karimi <mk3652@decaf.math.princeton.edu.private>
passing the 20/20 test cases and added Attributes + Methods to the Li…
9165226 
…ne class [need fix]
finished multidim test
1bca0a9
removed unused statements
f3a0925
initial fft changes
a1eba5b
stashing gpu fixes
de5388f
forward gpu
01d5995
changed backproject to run on gpu (cupy)
b9bee17
revert config
0007b52
fixed gpu issues
8952f53
@certifiedp certifiedp closed this Aug 2, 2024
@garrettwrong garrettwrong mentioned this pull request Aug 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janden janden Awaiting requested review from janden janden will be requested when the pull request is marked ready for review janden is a code owner

@garrettwrong garrettwrong Awaiting requested review from garrettwrong garrettwrong will be requested when the pull request is marked ready for review garrettwrong is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@certifiedp @garrettwrong @j-c-c