New Line Class with Back Project Method #1164
Conversation
j-c-c
left a comment
j-c-c
left a comment
There was a problem hiding this comment.
Looks good overall. Mostly just some clean up suggestions.
I do have some concern about the testing tolerance for back_project. When I visually inspect our reconstructions they look like a faded version of scikit's.
garrettwrong
force-pushed
the
backlineproject
branch
from
ebb7f5a to
83ab61f
Compare
|
Added normalization and angle fixes for backproject. Tightened mask very slightly. Able to get correspondence with scikit to 0.25% error. Fixed axes for backproject multidim stack test. |
j-c-c
left a comment
j-c-c
left a comment
There was a problem hiding this comment.
This looks great! Just a couple really small things.
garrettwrong
left a comment
garrettwrong
left a comment
There was a problem hiding this comment.
Looks good, thanks! Couple of minor changes then this should be good to move forward. Thanks!
garrettwrong
force-pushed
the
backlineproject
branch
from
5a9aac1 to
ec61591
Compare
janden
left a comment
janden
left a comment
There was a problem hiding this comment.
This looks great! Just two things to discuss here.
garrettwrong
force-pushed
the
backlineproject
branch
from
a8c8c56 to
1bc346f
Compare
[skip ci] Co-authored-by: Marc Karimi <mk3652@decaf.math.princeton.edu.private>
…ne class [need fix]
garrettwrong
force-pushed
the
backlineproject
branch
from
1bc346f to
4d86b1e
Compare
Changes Include
Lineclass (closely similar to that of theImageclass but with different attributes)back_projectmethod which takes a line class instance and turns it into an image using a given number of angles