Cl mask patch #1171
Merged
Cl mask patch #1171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Confirmed this greatly improved the CL indices wrt MATLAB reference. |
j-c-c
approved these changes
Sep 3, 2024
Collaborator
j-c-c
left a comment
j-c-c
left a comment
There was a problem hiding this comment.
Looks good to me. Now I'm wondering where I got that default from. Either way, I'm glad this gets us one step closer. Thanks for fixing this!
Collaborator
Author
|
The default was the same default as their function, so that is fine. It just happened that in use the default was not the value used 🤸♂️ . |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some differences in the application of
fuzzy_mask. I will retest to confirm, but it appears applying these two patches will reproduce the image stack going into the Polar Fourier transform just prior to the CL search and reduce the CL errors wrt MATLAB.