-
Notifications
You must be signed in to change notification settings - Fork 26
osx_arm updates #1174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osx_arm updates #1174
Conversation
f870123 to
8ae41ed
Compare
|
Had to patch a few more tests than I hoped, but overall I don't think we did too bad for a totally different architecture 😎 . We may find a few more as it begins to run regularly, but they should mainly just be adding an appropriate tolerance (1e-6 seems to be working well for stuff; mainly seeing small diffs in singles). Here is the run from my M1 mini: |
j-c-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one comment.
j-c-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
091e5b6 to
1734261
Compare
|
No functional changes, just the CI and some testing tolerances. Merging. |
Now that I have removed PyFFTW, pyshtools, and updated to FINUFFT 2.3.0 I think ASPIRE should be good to run native M1 out of the box. This PR patches the CI and removes the mention of the x86_64 conda install/workarounds.
I'll confirm with my own M1 machine a little later this morning before sending this for review.