minimal changes to restore simulation gallery for release #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettwrong
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1189 +/- ##
========================================
Coverage 87.37% 87.37%
========================================
Files 131 131
Lines 13603 13603
========================================
Hits 11886 11886
Misses 1717 1717 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found two issues here.
First, the pixel size was manually prescribed in CTFFilter, mismatched, and raised with the new logic. Missing that was my oversight. I did not run the experiments as part of the testing. I'm feeling good about being able to run these (or something like thme) regularly once the CUDA code is in.
Second, the whitening filter changes seemed to have broke this pipeline and I was forced to run the sim/recon as doubles. Previously it ran for both double and single precision, and was singles as published the last few years. Since we already spent a fair amount of time on this the last go and didn't get it quite right, I don't think it is a good idea to hold up the release for it now.... So lets get this merged in and that area will need to be revisited as one of the first things in this next release cycle.