Skip to content

Add Python 3.12, drop 3.8 #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2024
Merged

Add Python 3.12, drop 3.8 #1193

merged 5 commits into from
Oct 10, 2024

Conversation

@garrettwrong
Copy link
Collaborator

@garrettwrong garrettwrong commented Oct 9, 2024

Moves default Python to 3.9 in docs and environments.

@garrettwrong garrettwrong added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers CI Continuous Integration dependencies Pull requests that update a dependency file labels Oct 9, 2024
@garrettwrong garrettwrong self-assigned this Oct 9, 2024
@garrettwrong garrettwrong requested a review from j-c-c October 9, 2024 14:07
@codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.37%. Comparing base (32e83b4) to head (b6514fb).
Report is 5 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1193      +/-   ##
===========================================
- Coverage    87.40%   87.37%   -0.03%     
===========================================
  Files          132      132              
  Lines        13635    13635              
===========================================
- Hits         11917    11913       -4     
- Misses        1718     1722       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@garrettwrong garrettwrong marked this pull request as ready for review October 9, 2024 15:30
@garrettwrong garrettwrong requested a review from janden as a code owner October 9, 2024 15:30
@garrettwrong
Copy link
Collaborator Author

garrettwrong commented Oct 9, 2024

Kicking off the additional CI platforms

@garrettwrong
Copy link
Collaborator Author

garrettwrong commented Oct 9, 2024

This is "waiting on 3.8" because I will need to adjust the CI requirements to drop 3.8.

@garrettwrong
Copy link
Collaborator Author

garrettwrong commented Oct 10, 2024

@j-c-c , can I get a review, thanks.

j-c-c
j-c-c approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, looks good. Sorry for the delay!

@garrettwrong garrettwrong merged commit 1820da8 into develop Oct 10, 2024
44 checks passed
@garrettwrong garrettwrong deleted the adddropPython branch October 10, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-c-c j-c-c j-c-c approved these changes

@janden janden Awaiting requested review from janden janden is a code owner

Assignees

@garrettwrong garrettwrong

Labels

CI Continuous Integration dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garrettwrong @j-c-c