-
Notifications
You must be signed in to change notification settings - Fork 26
Cleanup Duplicate Code #1280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Duplicate Code #1280
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1280 +/- ##
===========================================
+ Coverage 90.58% 90.61% +0.03%
===========================================
Files 132 132
Lines 14162 14105 -57
===========================================
- Hits 12828 12781 -47
+ Misses 1334 1324 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Minor string update and quick questions, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Resolves #1233
Removes duplicate code found in both
src/aspire/utils/coor_trans.pyandsrc/aspire/utils/rotation.py.Also, I refactored
mean_aligned_angular_distanceto use the alignment code which now resides in theRotationclass in a way to not change the API. It might make sense to move this function into theRotationclass as well, but it will change the API.