-
Notifications
You must be signed in to change notification settings - Fork 26
Legacy Preprocess Example #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[skip ci]
|
Currently we achieve normalized per image results to about single precision using the script above at 129px. I'm re-running the MATLAB workflow at 179 to confirm that, and expect the same there. This PR also adds some minor changes to the normalize_psd option and exposes that option at a higher level, though it is still unused by default. I was testing to see if it could resolve the remaining absolute difference between the codes, but I've determined it was not the source of the diff. The changes will make the intermediate PSD closer to the MATLAB if a user decides to use it. (In MATLAB the PSD is computed and returned by one function, and the whitening performed by another which renormalizes the PSD again). To yield absolute diffs to single precision would require lifting MATLAB's whitening to double precision, and/or otherwise altering the MATLAB code. I narrowed it down to a few lines which can be discussed as needed. Regardless the normalized error is tight. It would have just been nice to get the final absolute tight as well, alas. I'll confirm the 179 results are where I want them before merging. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1323 +/- ##
========================================
Coverage 90.60% 90.60%
========================================
Files 133 133
Lines 14394 14394
========================================
Hits 13042 13042
Misses 1352 1352 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
For 179px the script achieved a max abs diff wrt MATLAB with the documented prompts of 0.0021972656 across all pixels of all images in the dataset, which constitutes a relative error of 3.3073989e-06 % when normalized per image. I will merge this after the CI passes, tag the merged commit for future reference, and notate the same in the issue. |
Adds a file showing equivalent Python commands for a legacy MATLAB workflow run on the 10028 dataset.