GPU CI #726
Merged
GPU CI #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettwrong
added
enhancement
Collaborator
Author
|
Noting I should update documentation (readme) as part of this PR. |
garrettwrong
force-pushed
the
gpu_utests
branch
from
ca2f3de to
e653bb8
Compare
Co-authored-by: Chris Langfield <christopher.langfield@gmail.com>
cast to doubles \(and back\) as needed
garrettwrong
force-pushed
the
gpu_utests
branch
from
ca2f3de to
584f289
Compare
Codecov Report
@@ Coverage Diff @@
## develop #726 +/- ##
===========================================
- Coverage 88.00% 87.95% -0.06%
===========================================
Files 114 114
Lines 8793 8798 +5
===========================================
Hits 7738 7738
- Misses 1055 1060 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chris-langfield
previously approved these changes
Nov 1, 2022
Collaborator
chris-langfield
left a comment
chris-langfield
left a comment
There was a problem hiding this comment.
This looks great just had a few questions
chris-langfield
approved these changes
Nov 1, 2022
Collaborator
Author
|
I think we can merge this and see how |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should have the required pieces to enable GPU based Github CI using
decaf. That should unblock some GPU development/integration opportunities.I have been unable to solve the singles bug with cufinufft on the A100 so far. Although I am still making progress, to be pragmatic I think it would be best to get what we can working now while the bug chase it back burnered. (Unfortunately I was not able to use that time most efficiently...)