Simplify Fourier-Bessel basis list of zeros #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #776 +/- ##
===========================================
- Coverage 88.53% 88.53% -0.01%
===========================================
Files 112 112
Lines 8760 8756 -4
===========================================
- Hits 7756 7752 -4
Misses 1004 1004
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chris-langfield
requested review from
garrettwrong and
janden
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close out #609
It turned out the
m_reshapewas totally unnecessary in the first place: you could achieve the same effect by doingnp.array(zeros).T!This test turns
basis.r0from an array of shape(max_num_zeros, ell_max)(i.e., the first dimension tracks the zeros of a given Bessel function, while the second tracks the Bessel order) to a list of lengthell_max, where the i'th element is a 1d numpy array containing exactly as many zeros as we have for Bessel order i. That is, it is a ragged list.