Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

@garrettwrong garrettwrong commented Feb 24, 2023

Try windows server 2019 instead of latest (2022).

Please disregard this PR. I'm just triggering the CI to see if this has the same failed test as windows 2022.

If it fails this PR will be removed. Succeeds, I will edit this message.

CI is reporting success using Win2019. I would like to merge this patch. Will leave issue open so we can revisit what is unhappy in Windows Server 2022 at a later date.

@garrettwrong garrettwrong added bug Something isn't working CI Continuous Integration labels Feb 24, 2023
@garrettwrong garrettwrong self-assigned this Feb 24, 2023
@garrettwrong garrettwrong requested a review from janden as a code owner February 24, 2023 11:41
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #865 (f7ed97f) into develop (06deb39) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #865   +/-   ##
========================================
  Coverage    88.69%   88.69%           
========================================
  Files          116      116           
  Lines         9440     9440           
========================================
  Hits          8373     8373           
  Misses        1067     1067           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@garrettwrong garrettwrong requested a review from j-c-c February 24, 2023 12:11
@garrettwrong
Copy link
Collaborator Author

Works around #862

@garrettwrong garrettwrong changed the title TESTING Downgrade windows CI from 2022 to 2019 (fixes single test fail in CI) Feb 24, 2023
@garrettwrong garrettwrong merged commit e9d5e91 into develop Feb 24, 2023
@garrettwrong garrettwrong deleted the fle_win_version_check branch February 24, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants