Conversation
goosenotduck
suggested changes
Dec 6, 2025
Contributor
goosenotduck
left a comment
goosenotduck
left a comment
There was a problem hiding this comment.
This is an awful solution to the problem. Just because the project is already messy doesn't mean we should add equally bad code on top. A JSON environment variable is mega cursed.
In my mind, the proper solution is to add each configuration option as it's own environment variable.
BigSpaceships
force-pushed
the
fix-secrets
branch
from
547be8a to
46e065a
Compare
BigSpaceships
changed the title
goosenotduck
suggested changes
Dec 8, 2025
Contributor
goosenotduck
left a comment
goosenotduck
left a comment
There was a problem hiding this comment.
I am not going to entertain this as long as GOOGLE_CLIENT_SECERTS_JSON exists.
costowell
reviewed
Jan 25, 2026
Contributor
costowell
left a comment
costowell
left a comment
There was a problem hiding this comment.
Undo approve, I'm not sure what's going on
costowell
requested changes
Jan 25, 2026
Contributor
costowell
left a comment
costowell
left a comment
There was a problem hiding this comment.
Undo approve, I'm not sure what's going on
costowell
approved these changes
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update dockerfile to expose port gunicorn actually listens on
Also update readme
Why
The dockerfile exposes 5000 but gunicorn listens on 8000 by default
Test Plan
uhhh run locally I'm not sure, running with command from old readme works but is cursed
Env Vars
nothing new
Checklist