This repository was archived by the owner on Feb 3, 2024. It is now read-only.
Initial working upvote/downvotes #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxmeinhold
reviewed
Feb 2, 2019
Contributor
mxmeinhold
left a comment
mxmeinhold
left a comment
There was a problem hiding this comment.
Really excited for this, but consider adjusting your route return values.
| vote = Vote(quote, submitter, direction) | ||
| db.session.add(vote) | ||
| db.session.commit() | ||
| return '200' |
Contributor
There was a problem hiding this comment.
Flask responses have a couple different forms (docs).
If you return a string, it will form a response with that string as the body and a status code of 200 OK.
If you want to specify the status code or headers, you can return a tuple in either of the following forms:
- (body, status, headers)
- (body, headers)
This means that when you return '201', it gives a response with a body of '201' and a status code of 200 OK
You could return a JSON success message:
return jsonify(success=True)For line 132, you can use a similar style while specifying the response code:
return jsonify(success=True), 201There are a few other ways you could achieve this, this is just the one I think of first.
dantayy
approved these changes
Feb 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.