Sourcery Starbot ⭐ refactored ComputerScientist-01/Advanced-Programming-Practice #16

SourceryAI · 2021-07-08T16:12:16Z

Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨

Here's your pull request refactoring your most popular Python repo.

If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.

Review changes via command line

To manually merge these changes, make sure you're on the main branch, then run:

git fetch https://github.com/sourcery-ai-bot/Advanced-Programming-Practice main
git merge --ff-only FETCH_HEAD
git reset HEAD^

SourceryAI · 2021-07-08T16:12:17Z

Week 1/SET 11/Task-5.py

-tot = 0
 print("Enter Marks Obtained in different exams: ")
 for i in range(5):
    marks.insert(i, input())
    #print(marks[i])

-for i in range(5):
-    tot = tot + int(marks[i])
+tot = sum(int(marks[i]) for i in range(5))


Lines 3-10 refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)

Convert for loop into call to sum() (sum-comprehension)

SourceryAI · 2021-07-08T16:12:17Z

Week 1/SET 14/ques4.py

-    sum = 0
-    for digit in str(n):   
-        sum += int(digit)        
+    sum = sum(int(digit) for digit in str(n))


Function sumofDigits refactored with the following changes:

Convert for loop into call to sum() (sum-comprehension)

SourceryAI · 2021-07-08T16:12:17Z

Week 2/SET 11/q1.py

-     
+
    temp = num;
-    while(temp):
+    while (temp):
        last_digit = temp % 10;
        temp = int(temp / 10);
-         
+
        dec_value += last_digit * base;
-        base = base * 2;
+        base *= 2;


Function binaryToDecimal refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)

SourceryAI · 2021-07-08T16:12:18Z

Week 2/SET 11/q2.py

-    for x in range(max(num,0)):
-      print(row)
-      row=[l+r for l,r in zip(row+y, y+row)]
+    for _ in range(max(num,0)):
+        print(row)
+        row=[l+r for l,r in zip(row+y, y+row)]


Function pascal_triangle refactored with the following changes:

Replace unused for index with underscore (for-index-underscore)

SourceryAI · 2021-07-08T16:12:18Z

Week 2/SET 11/q4.py

-m = dict()
+m = {}
 li = ['x','y','z']
 s = 11;
 for l in li:
-    val = list()
-    for i in range(9):
+    val = []
+    for _ in range(9):
        val.append(s)
        s+=1
-    s = s+1
+    s += 1
    m[l] = val
 print(m)
-for k in m.keys():
-    print(m[k][4])
+for k, v in m.items():
+    print(v[4])


Lines 5-17 refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)

Replace list() with [] (list-literal)

Replace dict() with {} (dict-literal)

Remove unnecessary call to keys() (remove-dict-keys)

Replace unused for index with underscore (for-index-underscore)

Use items() to directly unpack dictionary values (use-dict-items)

SourceryAI · 2021-07-08T16:12:19Z

Week-5/form.py

-    i = 0
-    for STFORM3 in select:
+    for i, STFORM3 in enumerate(select):
        for j in range(len(STFORM3)):
            e = Entry(my_w, width=10, fg='blue')
            e.grid(row=i, column=j)
            e.insert(END, STFORM3[j])
-        i = i+1


Function display refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)

Replace manual loop counter with call to enumerate (convert-to-enumerate)

SourceryAI · 2021-07-08T16:12:19Z

Week-5/registration_form_with_sql.py

    cursor.execute("SELECT * FROM user_details")
-    i=1 
-    for users in cursor: 
+    for i, users in enumerate(cursor, start=1): 


Function users_registered refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)

Replace manual loop counter with call to enumerate (convert-to-enumerate)

SourceryAI · 2021-07-08T16:12:20Z

Week-6/Mutliprogramming/Week06 Set08.py

    n = random.randint(10,20)
    if obj._value+n <= MAX:
-        for i in range(n):
+        for _ in range(n):


Function producer_func refactored with the following changes:

Replace unused for index with underscore (for-index-underscore)

SourceryAI · 2021-07-08T16:12:20Z

Week-6/Mutliprogramming/Week06 Set08.py

    n = random.randint(1,20)
    if obj._value+n >= 0:
-        for i in range(n):
+        for _ in range(n):


Function consumer_func refactored with the following changes:

Replace unused for index with underscore (for-index-underscore)

SourceryAI · 2021-07-08T16:12:20Z

Week-6/Mutliprogramming/Week06 Set10.py


 if __name__ == '__main__':
-    for i in range(0, 10):
+    for _ in range(10):


Lines 35-35 refactored with the following changes:

Replace range(0, x) with range(x) (remove-zero-from-range)

Replace unused for index with underscore (for-index-underscore)

SourceryAI · 2021-07-08T16:12:22Z

Week-6/Socket/Set3/server3.py

-    else:
-        pass


Lines 18-19 refactored with the following changes:

Remove redundant pass statement (remove-redundant-pass)

SourceryAI · 2021-07-08T16:12:23Z

Week-6/Socket/Set4/client4.py

        # We are going to check for both - if one of them - that's expected, means no incoming data, continue as normal
        # If we got different error code - something happened
-        if e.errno != errno.EAGAIN and e.errno != errno.EWOULDBLOCK:
+        if e.errno not in [errno.EAGAIN, errno.EWOULDBLOCK]:


Lines 79-79 refactored with the following changes:

Replace multiple comparisons of same variable with in operator (merge-comparisons)

'Refactored by Sourcery'

a62d6d2

SourceryAI commented Jul 8, 2021

View reviewed changes

ComputerScientist-01 merged commit 04e2d85 into ComputerScientist-01:main Jul 8, 2021

Sourcery Starbot ⭐ refactored ComputerScientist-01/Advanced-Programming-Practice #16

Sourcery Starbot ⭐ refactored ComputerScientist-01/Advanced-Programming-Practice #16

Uh oh!

Conversation

SourceryAI commented Jul 8, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants