Fix multiple issues, Add notice to Non Javascript Users, Make client not send the secret to the server when viewing pastes#5
Merged
ComputerTech312 merged 5 commits intoComputerTech312:mainfrom Sep 22, 2023
Juliaria08:clientleak
Merged
Fix multiple issues, Add notice to Non Javascript Users, Make client not send the secret to the server when viewing pastes#5ComputerTech312 merged 5 commits intoComputerTech312:mainfrom Juliaria08:clientleak
ComputerTech312 merged 5 commits intoComputerTech312:mainfrom
Juliaria08:clientleak
Conversation
This commit adds a notice for users that use browsers which don't contain javascript or have javascript disabled in their browsers to inform them that ElitePaste won't work without javascript.
We are using django which has jinja capabilities so make use of them
The client was accidentally sending the secret to the server when reading messages, this commit makes it so that doesn't happen.
Collaborator
Author
|
I know I probably should have split the commits up, but I was too lazy to do it afterwards. |
The secret is in the url and that's more of a developement like page but it's good to show the data.
Owner
|
I think we should leave out the Jinja template option for now, but the other features seem great. If you could reverse the Jinja template code, but leave the other new features. |
Collaborator
Author
|
Ok, I'll later do it.
El 21 de septiembre de 2023 20:44:53 CEST, Colby ***@***.***> escribió:
…I think we should leave out the Jinja template option for now, but the other features seem great. If you could reverse the Jinja template code, but leave the other new features.
|
Owner
Sounds good. |
This reverts commit b0879a7.
Collaborator
Author
|
I reverted jinja templates. |
Juliaria08
changed the title
Owner
|
Tested and accepted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing multiples issues at once.