Allow to debug without SSL#6
Merged
ComputerTech312 merged 1 commit intoComputerTech312:mainfrom Sep 21, 2023
Juliaria08:nossldebug
Merged
Allow to debug without SSL#6ComputerTech312 merged 1 commit intoComputerTech312:mainfrom Juliaria08:nossldebug
ComputerTech312 merged 1 commit intoComputerTech312:mainfrom
Juliaria08:nossldebug
Conversation
I'd rather not temporarily allow a public facing certificate to be able to authenticate to a website, and do fake SSL, if I do it I'd do it with a internally valid and private certificate. This commit checks if "DEBUG_NOSSL" exists and if exists, it binds to the older port without SSL configuration
ComputerTech312
approved these changes
Sep 21, 2023
Owner
ComputerTech312
left a comment
ComputerTech312
left a comment
There was a problem hiding this comment.
This is a good idea, hadn't thought about that.
Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd rather not temporarily allow a public facing certificate to be able
to authenticate to a website, and do fake SSL, if I do it I'd do it with
a internally valid and private certificate.
This commit checks if "DEBUG_NOSSL" exists and if exists, it binds to
the older port without SSL configuration.