Skip to content

Conversation

@Josh-Cena
Copy link
Member

  • Default language is Chinese (zh-Hans)
  • Provide translation to a few texts
  • TODO: translate the docs

- Default language is Chinese (zh-Hans)
- Provide translation to a few texts
- TODO: translate the docs
@netlify
Copy link

netlify bot commented Apr 22, 2021

Deploy preview built successfully 🎉

Built with commit df2785b

https://deploy-preview-294--cocky-bohr-d5033d.netlify.app

@Josh-Cena Josh-Cena requested review from SamChou19815 and yechs April 22, 2021 11:46
yechs
yechs previously approved these changes Apr 22, 2021
Copy link
Member

@yechs yechs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 不过我目前对 Docusaurus 的 i18n 还不是很熟悉

SamChou19815
SamChou19815 previously approved these changes Apr 22, 2021
@Josh-Cena Josh-Cena marked this pull request as ready for review April 25, 2021 03:29
Copy link
Member

@yechs yechs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@Josh-Cena Josh-Cena merged commit e841a60 into master Apr 25, 2021
@Josh-Cena Josh-Cena deleted the Josh-Cena/i18n branch April 25, 2021 04:01
@Josh-Cena Josh-Cena mentioned this pull request Apr 25, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants