Skip to content

fix: review typing in MXP #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2025
Merged

fix: review typing in MXP #742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06be2d0
fix: review typing in MXP
letypequividelespoubelles Sep 5, 2025
10004b1
Merge branch 'master' into 741-fix-cancun-reference-tests
letypequividelespoubelles Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mxp/cancun/columns/common.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
;; mdule will be used from Cancun fork and on

(defcolumns
( MXP_STAMP :i16 )
( CN :i64 )
( MXP_STAMP :i32 )
( CN :i32 )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Column Type Change Causes Integer Overflow

The CN column type changed from :i64 to :i32, significantly reducing its maximum storable value range. This could cause integer overflow, data truncation, or runtime errors if CN values exceed the 32-bit signed integer limit (-2,147,483,648 to 2,147,483,647).

Fix in Cursor Fix in Web

( DECODER :binary@prove )
( MACRO :binary@prove )
( SCENARIO :binary@prove )
Expand Down
Loading