Skip to content

[CI 3967] Add support for passing a list of itemIds to the recommendation view event #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2024
Merged

[CI 3967] Add support for passing a list of itemIds to the recommendation view event #146

merged 2 commits into from
Nov 25, 2024

Conversation

@jjl014
Copy link
Contributor

@jjl014 jjl014 commented Nov 22, 2024 •
edited
Loading

Updates:

  • Add support for passing item ids to recs view event
  • Add/update tests
  • Update README with new function signature (version mentioned there may need to change depending on when we are able to get this out)

Note: All tests pass, but quiz tests are failing which are also happening on master. We'll want to resolve this at some point.

@jjl014 jjl014 requested a review from a team November 22, 2024 01:39
stanlp1
stanlp1 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@stanlp1 stanlp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjl014 jjl014 merged commit a3869cd into master Nov 25, 2024
@jjl014 jjl014 deleted the ci-3967-android-sdk-add-support-for-passing-a-list-of-itemsitem_ids branch November 25, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stanlp1 stanlp1 stanlp1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jjl014 @stanlp1