[CDX-292] Remove Unnecessary Location Permissions #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes unnecessary location permissions from the Android manifest and updates quiz-related integration tests to remove hardcoded quiz version IDs and fix incorrect method calls.
- Removes
ACCESS_COARSE_LOCATIONandACCESS_FINE_LOCATIONpermissions from the library's AndroidManifest.xml - Updates quiz integration tests to remove quiz version ID assertions and parameters
- Fixes a test that was incorrectly calling
getQuizResults()instead ofgetQuizNextQuestion()
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| library/src/main/AndroidManifest.xml | Removes location permission declarations that are no longer needed by the library |
| library/src/test/java/io/constructor/core/ConstructorIoIntegrationQuizTest.kt | Updates tests to remove quiz version ID usage and fixes method call in one test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
esezen
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing some unnecessary location permissions and fixing some quizzes tests