ch3225 foreground method added #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikzube
reviewed
Feb 13, 2019
| set(value) = preferences.edit().putLong(SESSION_LAST_ACCESS, value).apply() | ||
|
|
||
| fun getSessionId(sessionIncrementAction: ((String) -> Unit)? = null): Int { | ||
| fun getSessionId(sessionIncrementAction: ((String) -> Unit)? = null, forceIncrement: Boolean = false): Int { |
Contributor
There was a problem hiding this comment.
Does this force an increment even if the time threshold has not passed?
Contributor
Author
There was a problem hiding this comment.
yes, calling app foreground forces it, thats why i added this param
rubikzube
added a commit
that referenced
this pull request
Feb 21, 2019
* Update README.md * Ch2950/documentation (#19) * added sections number of results config parameters (#20) * rename api_key (#22) * added config object (#21) * ch3426 add uid parameter (#23) * ch4501 added purchase track event (#25) * ch3226 match tracking calls singatures to iOS calls (#26) * ch3225 foreground method added (#27)
rubikzube
added a commit
that referenced
this pull request
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.