added search funcionality #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikzube
reviewed
Apr 2, 2019
| return dataManager.getAutocompleteResults(query, params.toTypedArray()) | ||
| } | ||
|
|
||
| fun search(text: String, vararg facets: Pair<String, List<String>>, page: Int? = null, perPage: Int? = null, groupId: Int? = null): Observable<ConstructorData<SearchResponse>> { |
Contributor
There was a problem hiding this comment.
Why use vararg for facets?
Contributor
Author
There was a problem hiding this comment.
so you can define define multiple, I believe that it was requirement
rubikzube
reviewed
Apr 2, 2019
| return dataManager.getAutocompleteResults(query, params.toTypedArray()) | ||
| } | ||
|
|
||
| fun search(text: String, vararg facets: Pair<String, List<String>>, page: Int? = null, perPage: Int? = null, groupId: Int? = null): Observable<ConstructorData<SearchResponse>> { |
Contributor
There was a problem hiding this comment.
Can we rename search to getSearchResults to match getAutocompleteResults?
rubikzube
reviewed
Apr 2, 2019
| fun search(text: String, vararg facets: Pair<String, List<String>>, page: Int? = null, perPage: Int? = null, groupId: Int? = null): Observable<ConstructorData<SearchResponse>> { | ||
| val sessionId = preferenceHelper.getSessionId(sessionIncrementEventHandler) | ||
| val encodedParams: ArrayList<Pair<String, String>> = arrayListOf() | ||
| val params: ArrayList<Pair<String, String>> = arrayListOf() |
Contributor
There was a problem hiding this comment.
We create and add items to params, but I cannot see where it is read from.
Contributor
Author
There was a problem hiding this comment.
good point, its a bug we should put it to encoded params, as we build serach url dynamically due to shortcomings of http lib we use
rubikzube
reviewed
Apr 2, 2019
| } | ||
| }.toObservable() | ||
|
|
||
| fun search(text: String, encodedParams: Array<Pair<String, String>> = arrayOf()): Observable<ConstructorData<SearchResponse>> { |
Contributor
There was a problem hiding this comment.
Can we rename search to getSearchResults to match getAutocompleteResults?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.