Skip to content

[CSL 7] Convert Conversion to v2 Endpoint #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rubikzube merged 4 commits into from
Jun 25, 2021
Merged

[CSL 7] Convert Conversion to v2 Endpoint #63

rubikzube merged 4 commits into from
Jun 25, 2021

Conversation

@crgee1
Copy link
Contributor

@crgee1 crgee1 commented Jun 22, 2021 •
edited
Loading

  • Update to v2 endpoint and handle conversion types
  • Follow up PR to update v2 tests to check request body params

@crgee1 crgee1 requested a review from rubikzube June 23, 2021 16:02
rubikzube
rubikzube approved these changes Jun 24, 2021
View reviewed changes
library/src/test/java/io/constructor/core/ConstructorIoTrackingTest.kt
import kotlin.test.assertEquals
import kotlin.test.assertTrue

internal fun getRequestBody(request: RecordedRequest): Map<String, String> {
Copy link
Contributor

@rubikzube rubikzube Jun 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaaaaaas!

@rubikzube rubikzube merged commit de14e88 into master Jun 25, 2021
@rubikzube rubikzube deleted the csl-7-add-conversion-type-to-android-sdk branch June 25, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rubikzube rubikzube rubikzube approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crgee1 @rubikzube