[CSL-1711] Beacon: Add is_constructor_ab_cell to all behavioral events
#207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 7, 2022 13:38
jjl014
reviewed
Oct 10, 2022
Contributor
jjl014
left a comment
jjl014
left a comment
There was a problem hiding this comment.
Looks mostly good to me! Just left a couple of comments.
|
|
||
| describe('trackSessionStart', () => { | ||
| it('Should respond with a valid response', (done) => { | ||
| it.only('Should respond with a valid response', (done) => { |
Contributor
There was a problem hiding this comment.
Let's remove the .only here
| expect(fetchSpy).to.have.been.called; | ||
| expect(requestParams).to.have.property('key'); | ||
| expect(requestParams).to.have.property('i'); | ||
| expect(requestParams).to.have.property('is_constructor_ab_cell'); |
Contributor
There was a problem hiding this comment.
Can we also check the value of the property here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.