pylint pass

Author: einarf

.pylintrc

@@ -136,7 +136,8 @@ disable=print-statement,
         comprehension-escape,
         missing-docstring,
         duplicate-code,
-        no-member
+        no-member,
+        C0326
 
 
 # Enable the message, report, category or checker with the given id(s). You can

README.md

@@ -49,13 +49,11 @@ Features
 --------
 
 * A simple effect system based on python packages
-* Supports loading GLTF and obj files/scenes
+* Supports loading GLTF 2.0 and obj files/scenes
 * Support for the rocket sync-tracker system to create interesting keyframe data (Using [pyrocket](https://github.com/Contraz/pyrocket))
 * Management commands to create new projects and effects
 * Convenient wrappers for VAO, Shader, Texture, FBO etc
-* On-the-fly Shader and VAO negotiation of the needed buffer binding
 * Runtime re-loading shaders (press R)
-* Strict validation in most OpenGL operations with reasonable error feedback
 * Time line / Timer support
 * A highly pluggable framework
 * Support for custom management commands

TODO.md

@@ -25,7 +25,6 @@
 - Framebuffer Blitting
 - Textures:
   - 3D
-  - Texture Array
   - Texture Cube
 - FBOs
   - Support layers

demosys/conf/__init__.py

@@ -52,10 +52,10 @@ def __repr__(self):
             settings_module=self.SETTINGS_MODULE,
         )
 
-    def add_shader_dir(self, dir):
+    def add_shader_dir(self, directory):
         """Hack in shader directory"""
         dirs = list(self.SHADER_DIRS)
-        dirs.append(dir)
+        dirs.append(directory)
         self.SHADER_DIRS = dirs
 
 

demosys/conf/settingsfile.py

@@ -17,7 +17,7 @@ def create(settings):
             value = ",\n".join('    "{}": {}'.format(k, to_s(v)) for k, v in value.items())
 
             # Add comma after the last dict entry
-            if len(value) > 0:
+            if value:
                 value += ','
 
             data += "%s = {\n%s\n}\n\n" % (name, value)
@@ -26,7 +26,7 @@ def create(settings):
             value = ",\n".join("    {}".format(to_s(v)) for v in value)
 
             # Add comma after the last tuple entry
-            if len(value) > 0:
+            if value:
                 value += ","
 
             data += "{} = (\n{}\n)\n\n".format(name, value)
@@ -38,8 +38,8 @@ def create(settings):
     return data[:-1]
 
 
-def to_s(t):
-    if isinstance(t, str):
-        return '"{}"'.format(t)
+def to_s(var):
+    if isinstance(var, str):
+        return '"{}"'.format(var)
     else:
-        return str(t)
+        return str(var)

demosys/context/base.py

@@ -70,6 +70,8 @@ def swap_buffers(self):
 
     def resize(self, width, height):
         """Resize window"""
+        self.width = width
+        self.height = height
         self._calc_viewport()
 
     def close(self):

demosys/core/finders.py

@@ -30,8 +30,8 @@ def _find(self, path):
         :param path: The path to find
         :return: The absolute path to the file or None if not found
         """
-        for p in self.paths:
-            abspath = os.path.join(p, path)
+        for entry in self.paths:
+            abspath = os.path.join(entry, path)
             if os.path.exists(abspath):
                 self.cache(abspath, abspath)
                 return abspath
@@ -48,9 +48,9 @@ def find_cached(self, path):
         :param path: The path to the file
         :return: The absolute path to the file or None
         """
-        e = self._cache.get(path)
-        if e.exists:
-            return e.abspath
+        entry = self._cache.get(path)
+        if entry.exists:
+            return entry.abspath
         return None
 
     def cache(self, path, abspath, exists=True):

demosys/core/management/commands/run.py

@@ -19,8 +19,9 @@ def handle(self, *args, **options):
         print(manager_path)
         try:
             manager_cls = import_string(manager_path)
-        except ImportError as e:
-            raise ImproperlyConfigured("EFFECT_MANAGER '{}' failed to initialize: {}".format(manager_path, e))
+        except ImportError as err:
+            raise ImproperlyConfigured(
+                "EFFECT_MANAGER '{}' failed to initialize: {}".format(manager_path, err))
 
         manager = manager_cls()
         demosys.run(manager=manager)

demosys/deferred/effect.py

@@ -3,4 +3,6 @@
 
 
 class DeferredEffect(Effect):
-    pass
+
+    def draw(self, time, frametime, target):
+        pass

demosys/deferred/renderer.py

@@ -1,6 +1,6 @@
 import moderngl
 from demosys import context, geometry, resources
-from demosys.opengl import FBO, DepthTexture, Texture2D, samplers
+from demosys.opengl import FBO, DepthTexture, Texture2D
 from pyrr import matrix44
 
 
@@ -30,10 +30,6 @@ def __init__(self, width, height, gbuffer=None, lightbuffer=None):
         self.width = width
         self.height = height
         self.size = (width, height)
-        self.depth_sampler = samplers.create(
-            texture_compare_mode=False,
-            min_filter=moderngl.LINEAR, mag_filter=moderngl.LINEAR
-        )
 
         # FBOs
         self.gbuffer = gbuffer
@@ -113,16 +109,13 @@ def render_lights(self, camera_matrix, projection):
                 self.point_light_shader.uniform("m_light", m_light.astype('f4').tobytes())
                 self.gbuffer.color_buffers[1].use(location=0)
                 self.point_light_shader.uniform("g_normal", 0)
-                self.depth_sampler.use(location=1)
                 self.gbuffer.depth_buffer.use(location=1)
                 self.point_light_shader.uniform("g_depth", 1)
                 self.point_light_shader.uniform("screensize", (self.width, self.height))
                 self.point_light_shader.uniform("proj_const", projection.projection_constants)
                 self.point_light_shader.uniform("radius", light_size)
                 self.unit_cube.draw(self.point_light_shader)
 
-                self.depth_sampler.release()
-
         self.ctx.disable(moderngl.BLEND)
         self.ctx.disable(moderngl.CULL_FACE)