perf: Don’t subclass Error; resulting in smaller binary (angular#14160)

Subclassing errors is problematic since Error returns a
new instance. All of the patching which we do than prevent
proper application of source maps.

PR Close angular#14160

Author: mhevery

modules/@angular/common/src/pipes/async_pipe.ts

@@ -9,7 +9,7 @@
 import {ChangeDetectorRef, OnDestroy, Pipe, PipeTransform, WrappedValue} from '@angular/core';
 import {EventEmitter, Observable} from '../facade/async';
 import {isObservable, isPromise} from '../private_import_core';
-import {InvalidPipeArgumentError} from './invalid_pipe_argument_error';
+import {invalidPipeArgumentError} from './invalid_pipe_argument_error';
 
 interface SubscriptionStrategy {
   createSubscription(async: any, updateLatestValue: any): any;
@@ -120,7 +120,7 @@ export class AsyncPipe implements OnDestroy, PipeTransform {
       return _observableStrategy;
     }
 
-    throw new InvalidPipeArgumentError(AsyncPipe, obj);
+    throw invalidPipeArgumentError(AsyncPipe, obj);
   }
 
   private _dispose(): void {

modules/@angular/common/src/pipes/case_conversion_pipes.ts

@@ -7,7 +7,7 @@
  */
 
 import {Pipe, PipeTransform} from '@angular/core';
-import {InvalidPipeArgumentError} from './invalid_pipe_argument_error';
+import {invalidPipeArgumentError} from './invalid_pipe_argument_error';
 
 /**
  * Transforms text to lowercase.
@@ -21,7 +21,7 @@ export class LowerCasePipe implements PipeTransform {
   transform(value: string): string {
     if (!value) return value;
     if (typeof value !== 'string') {
-      throw new InvalidPipeArgumentError(LowerCasePipe, value);
+      throw invalidPipeArgumentError(LowerCasePipe, value);
     }
     return value.toLowerCase();
   }
@@ -48,7 +48,7 @@ export class TitleCasePipe implements PipeTransform {
   transform(value: string): string {
     if (!value) return value;
     if (typeof value !== 'string') {
-      throw new InvalidPipeArgumentError(TitleCasePipe, value);
+      throw invalidPipeArgumentError(TitleCasePipe, value);
     }
 
     return value.split(/\b/g).map(word => titleCaseWord(word)).join('');
@@ -65,7 +65,7 @@ export class UpperCasePipe implements PipeTransform {
   transform(value: string): string {
     if (!value) return value;
     if (typeof value !== 'string') {
-      throw new InvalidPipeArgumentError(UpperCasePipe, value);
+      throw invalidPipeArgumentError(UpperCasePipe, value);
     }
     return value.toUpperCase();
   }

modules/@angular/common/src/pipes/date_pipe.ts

@@ -9,7 +9,7 @@
 import {Inject, LOCALE_ID, Pipe, PipeTransform} from '@angular/core';
 import {NumberWrapper} from '../facade/lang';
 import {DateFormatter} from './intl';
-import {InvalidPipeArgumentError} from './invalid_pipe_argument_error';
+import {invalidPipeArgumentError} from './invalid_pipe_argument_error';
 
 const ISO8601_DATE_REGEX =
     /^(\d{4})-?(\d\d)-?(\d\d)(?:T(\d\d)(?::?(\d\d)(?::?(\d\d)(?:\.(\d+))?)?)?(Z|([+-])(\d\d):?(\d\d))?)?$/;
@@ -134,7 +134,7 @@ export class DatePipe implements PipeTransform {
       if ((typeof value === 'string') && (match = value.match(ISO8601_DATE_REGEX))) {
         date = isoStringToDate(match);
       } else {
-        throw new InvalidPipeArgumentError(DatePipe, value);
+        throw invalidPipeArgumentError(DatePipe, value);
       }
     }
 

modules/@angular/common/src/pipes/i18n_plural_pipe.ts

@@ -8,7 +8,7 @@
 
 import {Pipe, PipeTransform} from '@angular/core';
 import {NgLocalization, getPluralCategory} from '../localization';
-import {InvalidPipeArgumentError} from './invalid_pipe_argument_error';
+import {invalidPipeArgumentError} from './invalid_pipe_argument_error';
 
 const _INTERPOLATION_REGEXP: RegExp = /#/g;
 
@@ -37,7 +37,7 @@ export class I18nPluralPipe implements PipeTransform {
     if (value == null) return '';
 
     if (typeof pluralMap !== 'object' || pluralMap === null) {
-      throw new InvalidPipeArgumentError(I18nPluralPipe, pluralMap);
+      throw invalidPipeArgumentError(I18nPluralPipe, pluralMap);
     }
 
     const key = getPluralCategory(value, Object.keys(pluralMap), this._localization);

modules/@angular/common/src/pipes/i18n_select_pipe.ts

@@ -7,7 +7,7 @@
  */
 
 import {Pipe, PipeTransform} from '@angular/core';
-import {InvalidPipeArgumentError} from './invalid_pipe_argument_error';
+import {invalidPipeArgumentError} from './invalid_pipe_argument_error';
 
 /**
  * @ngModule CommonModule
@@ -32,7 +32,7 @@ export class I18nSelectPipe implements PipeTransform {
     if (value == null) return '';
 
     if (typeof mapping !== 'object' || typeof value !== 'string') {
-      throw new InvalidPipeArgumentError(I18nSelectPipe, mapping);
+      throw invalidPipeArgumentError(I18nSelectPipe, mapping);
     }
 
     if (mapping.hasOwnProperty(value)) {

modules/@angular/common/src/pipes/invalid_pipe_argument_error.ts

@@ -8,11 +8,8 @@
 
 import {Type} from '@angular/core';
 
-import {BaseError} from '../facade/errors';
 import {stringify} from '../facade/lang';
 
-export class InvalidPipeArgumentError extends BaseError {
-  constructor(type: Type<any>, value: Object) {
-    super(`Invalid argument '${value}' for pipe '${stringify(type)}'`);
-  }
+export function invalidPipeArgumentError(type: Type<any>, value: Object) {
+  return Error(`InvalidPipeArgument: '${value}' for pipe '${stringify(type)}'`);
 }

modules/@angular/common/src/pipes/number_pipe.ts

@@ -11,7 +11,7 @@ import {Inject, LOCALE_ID, Pipe, PipeTransform, Type} from '@angular/core';
 import {NumberWrapper} from '../facade/lang';
 
 import {NumberFormatStyle, NumberFormatter} from './intl';
-import {InvalidPipeArgumentError} from './invalid_pipe_argument_error';
+import {invalidPipeArgumentError} from './invalid_pipe_argument_error';
 
 const _NUMBER_FORMAT_REGEXP = /^(\d+)?\.((\d+)(-(\d+))?)?$/;
 
@@ -23,7 +23,7 @@ function formatNumber(
   // Convert strings to numbers
   value = typeof value === 'string' && NumberWrapper.isNumeric(value) ? +value : value;
   if (typeof value !== 'number') {
-    throw new InvalidPipeArgumentError(pipe, value);
+    throw invalidPipeArgumentError(pipe, value);
   }
 
   let minInt: number;

modules/@angular/common/src/pipes/slice_pipe.ts

@@ -7,7 +7,7 @@
  */
 
 import {Pipe, PipeTransform} from '@angular/core';
-import {InvalidPipeArgumentError} from './invalid_pipe_argument_error';
+import {invalidPipeArgumentError} from './invalid_pipe_argument_error';
 
 /**
  * @ngModule CommonModule
@@ -60,7 +60,7 @@ export class SlicePipe implements PipeTransform {
     if (value == null) return value;
 
     if (!this.supports(value)) {
-      throw new InvalidPipeArgumentError(SlicePipe, value);
+      throw invalidPipeArgumentError(SlicePipe, value);
     }
 
     return value.slice(start, end);

modules/@angular/common/test/pipes/date_pipe_spec.ts

@@ -59,7 +59,7 @@ export function main() {
          () => { expect(() => pipe.transform(isoStringWithoutTime)).not.toThrow(); });
 
       it('should not support other objects',
-         () => expect(() => pipe.transform({})).toThrowError(/Invalid argument/));
+         () => expect(() => pipe.transform({})).toThrowError(/InvalidPipeArgument/));
     });
 
     describe('transform', () => {

modules/@angular/compiler-cli/src/main.ts

@@ -13,8 +13,8 @@ import 'reflect-metadata';
 
 import * as ts from 'typescript';
 import * as tsc from '@angular/tsc-wrapped';
+import {isSyntaxError} from '@angular/compiler';
 
-import {SyntaxError} from '@angular/compiler';
 import {CodeGenerator} from './codegen';
 
 function codegen(
@@ -29,7 +29,7 @@ export function main(
   const cliOptions = new tsc.NgcCliOptions(args);
 
   return tsc.main(project, cliOptions, codegen).then(() => 0).catch(e => {
-    if (e instanceof tsc.UserError || e instanceof SyntaxError) {
+    if (e instanceof tsc.UserError || isSyntaxError(e)) {
       consoleError(e.message);
       return Promise.resolve(1);
     } else {