Skip to content

Remove alternative converter support #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Remove alternative converter support #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions convertapi/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,8 @@ def run(self):
params = self.__normalize_params()
from_format = self.from_format or self.__detect_format()
timeout = self.timeout + convertapi.conversion_timeout_delta if self.timeout else None
converter = self.__detect_converter()
path = "convert/%s/to/%s" % (from_format, self.to_format)

if converter != None:
path += "/converter/%s" % (converter)

response = convertapi.client.post(path, params, timeout = timeout)

return Result(response)
Expand Down Expand Up @@ -62,10 +58,3 @@ def __detect_format(self):

if 'Files' in self.params:
return format_detector.detect(self.params['Files'][0])

def __detect_converter(self):
for k, v in self.params.items():
if k.lower() == 'converter':
return v

return None
15 changes: 0 additions & 15 deletions examples/alternative_converter.py
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions tests/test_convertapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@ def test_convert_file_no_parallelizm(self):
result = convertapi.convert('pdf', { 'File': 'examples/files/test.docx' })
assert result.save_files(tempfile.gettempdir())

def test_convert_file_alternative(self):
result = convertapi.convert('pdf', { 'File': 'examples/files/test.docx', 'Converter': 'openoffice' })
assert result.save_files(tempfile.gettempdir())
assert result.conversion_cost > 0

def test_convert_file_url(self):
result = convertapi.convert('pdf', { 'File': 'https://cdn.convertapi.com/cara/testfiles/document.docx?test=1' })
assert result.conversion_cost > 0
Expand Down
Loading