Conversation
rydama
reviewed
Aug 31, 2020
|
|
||
| def start_expiration_window | ||
| return if current_requests.zero? | ||
| return if current_ttl.zero? |
There was a problem hiding this comment.
Your description of the ttl returns values made sense to me... so I don't understand why this checks for current_ttl.zero? instead of current_ttl.negative? Maybe this strategy is different somehow?
Collaborator
Author
There was a problem hiding this comment.
Oh yeah nice catch! It was just me being stupid, fixed that
rydama
approved these changes
Aug 31, 2020
rydama
left a comment
rydama
left a comment
There was a problem hiding this comment.
This seems like it should fix the issue I'm seeing 👍
Just one question about the use of current_ttl.zero? in the sliding window strategy.
ryakh
force-pushed
the
measure-expiration-window-against-ttl
branch
from
c161409 to
1c7a79c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.expirecommand on redis will returnfalseif performed on top of a key that does not exist andtrueif key exists..ttlon other hand returns-1if key has no expiration and-2if key does not exist.So this seems to be like a safe choice to go with so we can make rate limiting self-healing in case something taints the key.