Delete SDK requests array after loading error#711
Merged
cookpete merged 2 commits intocookpete:masterfrom Sep 17, 2019
Merged
Conversation
* now a SDK can be loaded after it failed to load once * reject all requests for one SDK when it fails to load
cookpete
force-pushed
the
fix-getsdk-errorhandling
branch
from
be231ab to
2e65010
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that loading an SDK permanently and silently fails after it failed to load once. That's because the resolves array for an SDK never gets cleaned after a loading error. This is fixed here.
If an error occurs while loading the SDK, all waiting requests for that SDK get rejected and the corresponding array gets deleted.