`copilot-core`: Remove module `Copilot.Core.PrettyDot`

[ivanperez-keera]

Description

The module Copilot.Core.PrettyDot is not being used by any other part of Copilot.

It was deprecated in Copilot 3.11 and no messages have been received requesting that it be kept in the implementation.

As per our internal policy of waiting 3 versions from deprecation until a public interface declaration can be removed, this module can now be removed.

Type

• Bug: unused code included in the implementation.

Additional context

• Issue copilot-core: module Copilot.Core.PrettyDot is unnecessary #359 , addressed in Copilot 3.11, deprecated the module.

Requester

• Ivan Perez

Method to check presence of bug

The following expression finds uses of Copilot.Core.PrettyDot, ignoring appearances in comments or strings.

$ grep -nHre '\<Copilot.Core.PrettyDot\>' --include='*.hs' | grep -ve '^{-#' | grep -ve '--.*Copilot.Core.PrettyDot' | grep -ve '"[^"]*Copilot.Core.PrettyDot[^"]*"'
copilot-core/src/Copilot/Core/PrettyDot.hs:8:module Copilot.Core.PrettyDot

The result obtained is just the module. There are no uses elsewhere.

Expected result

The string returned by the command above should be empty (module is not present) or list further uses. If the former, attempting to import Copilot.Core.PrettyDot, or any entities previously defined in it, should result in an error.

Desired result

The string returned by the command above should be empty. Attempting to import Copilot.Core.PrettyDot, or any entities previously defined in it, should result in an error.

Proposed solution

Remove the module Copilot.Core.PrettyDot.

Review the dependencies in case some are no longer needed.

Further notes

None.

[ivanperez-keera]

Change Manager: Confirmed that the issue exists.

[ivanperez-keera]

Technical Lead: Confirmed that the issue should be addressed.

[ivanperez-keera]

Technical Lead: Issue scheduled for fixing in Copilot 3.14.

Fix assigned to: @willpog .