Skip to content

Fix version label + use secure unity version #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 17, 2025
Merged

Fix version label + use secure unity version #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f5d56de
chore: update Unity version from 2021.3.45f1 to 2021.3.45f2
msanatan Oct 15, 2025
ba35a47
feat: add dynamic version display in editor window settings
msanatan Oct 15, 2025
a6ab3d9
refactor: remove manual license file handling from Unity test workflow
msanatan Oct 17, 2025
87c45ff
Revert "refactor: remove manual license file handling from Unity test…
msanatan Oct 17, 2025
01b8879
feat: add Unity license credentials to Docker containers in CI workflow
msanatan Oct 17, 2025
e9520ee
refactor: replace manual Unity license activation with game-ci/unity-…
msanatan Oct 17, 2025
4e5ffc0
refactor: simplify Unity CI setup by removing game-ci activation and …
msanatan Oct 17, 2025
a9f4c02
fix: improve Unity license activation in CI by using unityci image's …
msanatan Oct 17, 2025
f6a9aa6
refactor: activate once in a temporary container, then reuse the lic…
msanatan Oct 17, 2025
0708ace
Revert "refactor: activate once in a temporary container, then reuse…
msanatan Oct 17, 2025
e08779e
Revert "fix: improve Unity license activation in CI by using unityci …
msanatan Oct 17, 2025
b5bec1b
Revert "refactor: simplify Unity CI setup by removing game-ci activat…
msanatan Oct 17, 2025
172d7fd
Revert "refactor: replace manual Unity license activation with game-c…
msanatan Oct 17, 2025
0778e7c
Revert "feat: add Unity license credentials to Docker containers in C…
msanatan Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/claude-nl-suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ concurrency:
cancel-in-progress: true

env:
UNITY_IMAGE: unityci/editor:ubuntu-2021.3.45f1-linux-il2cpp-3
UNITY_IMAGE: unityci/editor:ubuntu-2021.3.45f2-linux-il2cpp-3

jobs:
nl-suite:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unity-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
testMode:
- editmode
unityVersion:
- 2021.3.45f1
- 2021.3.45f2
steps:
# Checkout
- name: Checkout repository
Expand Down
3 changes: 3 additions & 0 deletions MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ private enum ConnectionProtocol
}

// Settings UI Elements
private Label versionLabel;
private Toggle debugLogsToggle;
private EnumField validationLevelField;
private Label validationDescription;
Expand Down Expand Up @@ -191,6 +192,7 @@ private void RefreshAllData()
private void CacheUIElements()
{
// Settings
versionLabel = rootVisualElement.Q<Label>("version-label");
debugLogsToggle = rootVisualElement.Q<Toggle>("debug-logs-toggle");
validationLevelField = rootVisualElement.Q<EnumField>("validation-level");
validationDescription = rootVisualElement.Q<Label>("validation-description");
Expand Down Expand Up @@ -240,6 +242,7 @@ private void CacheUIElements()
private void InitializeUI()
{
// Settings Section
versionLabel.text = AssetPathUtility.GetPackageVersion();
debugLogsToggle.value = EditorPrefs.GetBool("MCPForUnity.DebugLogs", false);

validationLevelField.Init(ValidationLevel.Standard);
Expand Down
2 changes: 1 addition & 1 deletion MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.uxml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<ui:VisualElement class="section-content">
<ui:VisualElement class="setting-row">
<ui:Label text="Version:" class="setting-label" />
<ui:Label text="5.0.0" name="version-label" class="setting-value" />
<ui:Label text="..." name="version-label" class="setting-value" />
</ui:VisualElement>
<ui:VisualElement class="setting-row">
<ui:Label text="Show Debug Logs:" class="setting-label" />
Expand Down
4 changes: 2 additions & 2 deletions TestProjects/UnityMCPTests/ProjectSettings/ProjectVersion.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
m_EditorVersion: 2021.3.45f1
m_EditorVersionWithRevision: 2021.3.45f1 (0da89fac8e79)
m_EditorVersion: 2021.3.45f2
m_EditorVersionWithRevision: 2021.3.45f2 (88f88f591b2e)