Afos/io connections commands #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Accelerator `cosmo_api` can be found in `coal.cosmotech_api` - Accelerator `csm_engine` is moved to `coal.csm.engine` - Removed old `Core` folders - Removed `MultiEnvironment`
lalepee
approved these changes
Oct 3, 2024
| show_envvar=True, | ||
| required=True) | ||
| @click.option("--prefix", | ||
| "file_prefix", |
There was a problem hiding this comment.
Maybe change the name to "prefix_filter" to not confuse with a added prefix to file at upload.
| """Download S3 bucket content to a given folder | ||
| Make use of the default AWS/S3 configuration to access the bucket | ||
| Will download everything in the bucket unless a prefix is set, then only file following the given preix will be downloaded |
There was a problem hiding this comment.
Typo: at the end: the given preix will -> the given prefix will
| envvar="CSM_S3_CA_BUNDLE") | ||
| @web_help("csm-data/s3-bucket-load") | ||
| def s3_bucket_load(target_folder, bucket_name): | ||
| def s3_bucket_load( |
There was a problem hiding this comment.
Rename to s3_bucket_download to avoid confusion
| self.store_location = pathlib.Path(os.environ.get("CSM_PARAMETERS_ABSOLUTE_PATH", ".")) / ".coal/store" | ||
| def __init__( | ||
| self, | ||
| reset=False, |
There was a problem hiding this comment.
For a singleton I've understood but now it seem more confusing than useful. looks like a gimmick not to call the reset function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.