DA-1170 add index advisor support with two new tools #58
Conversation
Summary of ChangesHello @AayushTyagi1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the system's database optimization capabilities by integrating with the Couchbase Index Advisor. It provides new functionalities that allow users to automatically retrieve index recommendations for their SQL++ queries and then apply those recommendations by creating new indexes. This streamlines the process of improving query performance and managing database indexes more efficiently. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for the Couchbase Index Advisor by introducing two new tools: one for fetching index recommendations and another for creating indexes based on them. The implementation is well-structured, with good documentation and error handling. My review includes a few suggestions for the new src/tools/index.py file to improve API clarity by removing unused parameters and to enhance code readability with a minor simplification.
nithishr
left a comment
nithishr
left a comment
There was a problem hiding this comment.
The functionality works well overall. Just couple of things to clarify.
src/tools/index.py
Outdated
| raise | ||
|
|
||
|
|
||
| def create_index_from_recommendation( |
There was a problem hiding this comment.
Do we need this tool? This is not too different from the run_sql_plus_plus_query() right?
src/tools/index.py
Outdated
| logger.info("Running Index Advisor for the provided query") | ||
|
|
||
| # Execute the ADVISOR function at cluster level | ||
| result = cluster.query(advisor_query) |
There was a problem hiding this comment.
Can we use the run_cluster_query() in query tools?
That should get you the same results.
src/tools/index.py
Outdated
|
|
||
| try: | ||
| # Escape single quotes in the query by doubling them for SQL++ string literal | ||
| escaped_query = query.replace("'", "''") |
There was a problem hiding this comment.
Is this required? LLMs are generally pretty good at formatting the strings as required.
tests/test_index_advisor.py
Outdated
There was a problem hiding this comment.
Can we remove this test & it looks good otherwise
|
@nithishr |
Support GSI Index Tools + Advisor