Skip to content

Conversation

@nithishr
Copy link
Contributor

Refactor index advisor function to accept bucket and scope parameters, updating query execution method to run_sql_plus_plus_query.

  • This is in line with all the queries generated by the MCP server.

…, updating query execution method to run_sql_plus_plus_query.
@nithishr nithishr requested a review from AayushTyagi1 October 28, 2025 17:38
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @nithishr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the get_index_advisor_recommendations function to enable scope-level querying. By introducing bucket_name and scope_name parameters and migrating to run_sql_plus_plus_query, the index advisor tool now operates in a more granular and consistent manner with other queries generated by the MCP server, ensuring recommendations are contextually relevant to specific data scopes.

Highlights

  • Function Signature Update: The get_index_advisor_recommendations function now accepts bucket_name and scope_name parameters, allowing for more granular index recommendations.
  • Query Execution Method Change: The internal query execution has been switched from run_cluster_query to run_sql_plus_plus_query, aligning with standard MCP server query generation.
  • Scoped Query Execution: The index advisor tool now executes queries within a specified bucket and scope, ensuring recommendations are contextually relevant and consistent with other system queries.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request refactors the get_index_advisor_recommendations function to accept bucket_name and scope_name parameters, and updates the query execution method to run_sql_plus_plus_query. This change aligns with the query generation approach used by the MCP server. The review focuses on ensuring the correctness and maintainability of the changes.

@nithishr nithishr merged commit 28620e9 into main Oct 28, 2025
6 checks passed
@nithishr nithishr deleted the advisor_at_scope_level branch November 12, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants