Skip to content

Conversation

@nithishr
Copy link
Contributor

  • Package Capella certs to support pre built binaries & Docker setup
  • Restrict usage to Python 3.10-3.13

@nithishr nithishr requested a review from AayushTyagi1 October 31, 2025 17:56
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @nithishr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the project's Python environment compatibility by explicitly limiting support to Python versions 3.10-3.13. Concurrently, it streamlines the packaging and distribution process by ensuring that necessary Capella certificates are correctly bundled, facilitating smoother deployments in various environments, including Docker.

Highlights

  • Python Version Restriction: The project now explicitly restricts its supported Python versions to 3.10 through 3.13, excluding Python 3.14. This ensures compatibility and stability with known environments.
  • Capella Certificate Packaging: Capella root CA certificates are now properly packaged within the project, supporting pre-built binaries and Docker setups. This change improves the reliability of SSL verification for Capella connections.
  • Improved Certificate Path Resolution: The mechanism for locating the Capella root CA certificate has been enhanced to use importlib.resources for installed packages, with a robust fallback for development environments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request makes the project packageable by including the Capella certificate and restricting the supported Python versions. The use of hatchling for building and the attempt to use importlib.resources for accessing data files are good improvements. However, I've found a significant issue in how the certificate path is retrieved, which will cause problems when the package is installed as a zip archive. Please see my detailed comment. The other changes look good.

@nithishr nithishr merged commit 4a31c74 into feat/DA-1171-list-index-names-and-definitions Nov 3, 2025
2 checks passed
@nithishr nithishr deleted the cert_packaging branch November 12, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants