Skip to content

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Jul 17, 2024

Reverts #631

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (mli-feature@5fac3e2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
smartsim/_core/launcher/dragon/dragonBackend.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             mli-feature     #637   +/-   ##
==============================================
  Coverage               ?   59.31%           
==============================================
  Files                  ?       97           
  Lines                  ?     6690           
  Branches               ?        0           
==============================================
  Hits                   ?     3968           
  Misses                 ?     2722           
  Partials               ?        0           
Files with missing lines Coverage Δ
smartsim/_core/launcher/dragon/dragonLauncher.py 26.92% <ø> (ø)
smartsim/_core/launcher/step/dragonStep.py 37.09% <100.00%> (ø)
smartsim/_core/launcher/step/step.py 93.42% <100.00%> (ø)
smartsim/_core/schemas/dragonRequests.py 97.50% <100.00%> (ø)
smartsim/settings/dragonRunSettings.py 75.00% <ø> (ø)
smartsim/_core/launcher/dragon/dragonBackend.py 2.32% <0.00%> (ø)

@ankona ankona merged commit 0030a4a into mli-feature Jul 17, 2024
@ankona ankona deleted the revert-631-726 branch September 12, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant