Skip to content

Conversation

ankona
Copy link
Contributor

@ankona ankona commented Jul 31, 2024

Fix two dragon installation issues:

  1. Fix issue where search for *.whl files may include previously extracted versions of the dragon package
  2. Fix issue where LD_LIBRARY_PATH is incorrectly directed to dragon-0.9 folder by using the generated .env file created from smart build --dragon

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (mli-feature@9f482b1). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             mli-feature     #652   +/-   ##
==============================================
  Coverage               ?   65.73%           
==============================================
  Files                  ?       97           
  Lines                  ?     6760           
  Branches               ?        0           
==============================================
  Hits                   ?     4444           
  Misses                 ?     2316           
  Partials               ?        0           

@ankona ankona requested review from AlyssaCote and mellis13 July 31, 2024 15:40
@ankona ankona force-pushed the drg-install-patch2 branch 7 times, most recently from e24aad3 to 05038ad Compare August 1, 2024 00:22
@ankona ankona force-pushed the drg-install-patch2 branch from 0a74871 to f7029b0 Compare August 1, 2024 02:51
Copy link
Contributor

@AlyssaCote AlyssaCote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on the changelog, but pending tests pass, this LGTM!

@ankona ankona force-pushed the drg-install-patch2 branch 2 times, most recently from 5edb0c2 to c42bda6 Compare August 1, 2024 20:49
@ankona ankona force-pushed the drg-install-patch2 branch from c42bda6 to 2617d6a Compare August 1, 2024 20:53
@ankona ankona merged commit 263e3c7 into CrayLabs:mli-feature Aug 2, 2024
@ankona ankona deleted the drg-install-patch2 branch September 25, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants