Skip to content

Feature: Facebook Authentication #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 5, 2020
Merged

Feature: Facebook Authentication #41

merged 8 commits into from
Jun 5, 2020

Conversation

@TOPOFGR
Copy link
Contributor

@TOPOFGR TOPOFGR commented Jun 2, 2020 •
edited
Loading

Details:

  • Modified Log in Interface

  • Users can now log in and sign in via Facebook

  • Users can not sign in with Facebook if the email is already on the database

@TOPOFGR TOPOFGR requested review from MateoKruk and tpiaggio June 2, 2020 21:07
@TOPOFGR TOPOFGR self-assigned this Jun 2, 2020
@tpiaggio tpiaggio force-pushed the feature/facebook-auth branch from 6eb729e to 32a1338 Compare June 2, 2020 23:01
@tpiaggio tpiaggio added the enhancement New feature or request label Jun 3, 2020
MateoKruk
MateoKruk suggested changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@MateoKruk MateoKruk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should unit testing this feature, at the moment we only added tests for the reducers but it's important to test the UI in conjunction with the redux actions.

@TOPOFGR TOPOFGR requested a review from MateoKruk June 3, 2020 18:29
MateoKruk
MateoKruk approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@MateoKruk MateoKruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TOPOFGR TOPOFGR changed the title Facebook Authentication Feature: Facebook Authentication Jun 5, 2020
@TOPOFGR TOPOFGR changed the base branch from master to feature/facebook-google-microsoft-auth June 5, 2020 19:38
@TOPOFGR TOPOFGR merged commit e619c8d into feature/facebook-google-microsoft-auth Jun 5, 2020
@TOPOFGR TOPOFGR deleted the feature/facebook-auth branch June 5, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tpiaggio tpiaggio Awaiting requested review from tpiaggio

1 more reviewer

@MateoKruk MateoKruk MateoKruk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TOPOFGR TOPOFGR

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TOPOFGR @MateoKruk @tpiaggio