Skip to content

Conversation

@MateoKruk
Copy link
Contributor

@MateoKruk MateoKruk commented Jun 3, 2020

Migrated all the cloud functions project into Typescript also included TSLint for linting.

Also refactored the HTTP function to be directly callable by the client sdk. This improves speed and security. Now Firebase automatically decodes the firebase token and verify's it when the function is invoked. This prevents someone to call the function directly without the sdk.

Callable functions

@MateoKruk MateoKruk requested review from jfocco and tpiaggio June 3, 2020 20:19
@MateoKruk MateoKruk self-assigned this Jun 3, 2020
Copy link
Member

@tpiaggio tpiaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@MateoKruk MateoKruk requested a review from tpiaggio June 4, 2020 18:45
Copy link
Member

@tpiaggio tpiaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@MateoKruk MateoKruk merged commit fd78fe1 into master Jun 5, 2020
@MateoKruk MateoKruk deleted the feature/migrate-functions-ts branch June 5, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants