Update badge #232
Update badge #232
Conversation
| dispatch(updateLabelSuccess(label)); | ||
| } | ||
| } catch (e) { | ||
| // To do |
There was a problem hiding this comment.
you should really start working on a general error handler instead of sprinkling todos all over your codebase
| it('should update label: less badge', () => { | ||
| const data = Map({ | ||
| [labels[0].id]: Map({ | ||
| id: labels[0].id, |
There was a problem hiding this comment.
use const firstLabel = labels[0]
There was a problem hiding this comment.
In the test I don't mind if it is the first, second, whatever label.... it just take a label to test.
There was a problem hiding this comment.
so what?it is still repetitive. use const [anyLabel] = labels
| }); | ||
| const action = actions.updateLabelSuccess({ id: 1, badgeOperation: -1 }); | ||
| const state = labelReducer(data, action); | ||
| expect(state).toMatchSnapshot(); |
There was a problem hiding this comment.
dont abuse snapshots, the expect API has more appropriate methods for this
| const action = actions.updateLabelSuccess({ id: 1, badgeOperation }); | ||
| const state = labelReducer(data, action); | ||
| expect(state.get('1').get('badge')).toEqual( | ||
| data.get('1').get('badge') + badgeOperation |
There was a problem hiding this comment.
this is hard to read. why not use expect toEqual arrayContaining expectedBadge.
| it('should update label: less badge', () => { | ||
| const data = Map({ | ||
| [labels[0].id]: Map({ | ||
| id: labels[0].id, |
There was a problem hiding this comment.
so what?it is still repetitive. use const [anyLabel] = labels
3 participants
No description provided.