Decouple email_login validators from electron #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-gabriel
force-pushed
the
gabriel
branch
9 times, most recently
from
3c3cdfc to
c345804
Compare
Don't require electronInterface in email_login's validator. Hardcode some numeric constants directly in validator module. Use isemail instead of validator for smaller bundle sizes.
Don't require electronInterface in SignUpWrapper so that SignUpWrapper can run in the browser. Expose function props in SignUpWrapper so that the parent can supply the functionality that was provided by electronInterface. Add SignUpElectronWrapper, a component built on top of SignUpWrapper that passes electronInterface methods as props. Improve error handling in LoginWrapper.js
Use CSS modules feature.
Add scripts at the root of the project for easier development: install.js and start.js. Update README.md
Delay API calls to check username Use appropriate error messages for each status code.
erikaperugachi
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't require electronInterface in email_login's validator. Hardcode
some numeric constants directly in validator module.
Use isemail instead of validator for smaller bundle sizes.