Fix compatibility with Kubernetes 1.25#3370
Conversation
|
Hey @cbandy, would you normally review a change like this? I'm looking for PGO support on 1.25 |
|
Hi @jelmer! I just wanted to quickly reach out let you know that we're currently working on some dependency updates in the following PR, which we will be working in-front of some planned updates to enable Kubernetes 1.25 support in PGO: #3362. Therefore, I did want to be sure you were aware that we are planning to add support Kubernetes 1.25 in the coming weeks once #3362 is merged. We are happy to review this PR at that time (so feel free to leave it open!), but some changes/updates will likely be required. |
|
Hi Andrew, Thanks for the heads-up. Happy to update this PR once the other changes happen. |
|
Hi @jelmer, Second, I'm hoping to merge the dependency update sometime this week, which includes changes like a generic logging update, the Handler=>ProbeHandler change, and the patch change. Since I'm handling that, could you simplify this PR to focus on the API deprecations for policyv1 and batchv1? That would be very helpful. |
593926a to
c0c0137
Compare
2f9dcd8 to
71f5e37
Compare
|
@benjaminjb done, rebased on your branch. |
|
Hey @jelmer thanks, my branch was still in-progress when you rebased -- can you maybe rebase off |
71f5e37 to
3893b3b
Compare
|
@benjaminjb done |
|
Two things the linter caught:
|
This changes in particular: * policyv1beta1.PodDisruptionBudget => policyv1.PodDisruptionBudget * batchv1beta1.CronJob => batchv1.CronJob
3893b3b to
d628e71
Compare
|
Fixed! |
Co-authored-by: Benjamin Blattberg <benjamin.blattberg@gmail.com>
Add support for Kubernetes 1.25.
Move to CRDs removed in Kubernetes 1.25:
Issue: #3365