Update crd-docs #3391
Merged
Update crd-docs #3391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminjb
force-pushed
the
crd-doc-update
branch
3 times, most recently
from
9d3f71e to
e712c82
Compare
Contributor
Author
|
Golangci is failing because of trailing spaces in some descriptions (TopologySpreadConstraint.minDomains and grpc.Services) (I tried changing them by hand rather than producing a patch kustomize file, but that fails the check-generate test.) |
Issue: [sc-12818]
benjaminjb
force-pushed
the
crd-doc-update
branch
from
e712c82 to
14a51e6
Compare
cbandy
approved these changes
Sep 27, 2022
benjaminjb
force-pushed
the
crd-doc-update
branch
5 times, most recently
from
010be57 to
7872c00
Compare
cbandy
approved these changes
Sep 28, 2022
.github/workflows/lint.yaml
Outdated
| # The `documentation-crd` job only checks the crd.md for `TODO`, | ||
| # as some of the upstream documentation has trailing spaces | ||
| - run: | | ||
| find docs/content/references/crd.md -print0 | xargs -0 awk ' |
Member
There was a problem hiding this comment.
⛏️ maybe find docs/content -name crd.md to complement the other find.
This splits the GH linter action that was checking for TODOs and trailing spaces in the documentation into two actions: * one that checks TODOs and trailing spaces in all files except the crd * one that checks TODOs only in the crd.md file
benjaminjb
force-pushed
the
crd-doc-update
branch
from
7872c00 to
44e24be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
What is the new behavior (if this is a feature change)?
Other Information:
Issue: [sc-12818]