Skip to content

Enable all feature gates during development #4062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Enable all feature gates during development #4062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7952ee1
Enable all feature gates during development
cbandy Oct 16, 2024
c7b9ba4
Move CGO requirement to the effected code
cbandy Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ undeploy: ## Undeploy the PostgreSQL Operator

.PHONY: deploy-dev
deploy-dev: ## Deploy the PostgreSQL Operator locally
deploy-dev: PGO_FEATURE_GATES ?= "TablespaceVolumes=true,VolumeSnapshots=true"
deploy-dev: PGO_FEATURE_GATES ?= "AllAlpha=true"
deploy-dev: get-pgmonitor
deploy-dev: build-postgres-operator
deploy-dev: createnamespaces
Expand All @@ -145,7 +145,7 @@ deploy-dev: createnamespaces
##@ Build - Binary
.PHONY: build-postgres-operator
build-postgres-operator: ## Build the postgres-operator binary
CGO_ENABLED=1 $(GO_BUILD) $(\
$(GO_BUILD) $(\
) --ldflags '-X "main.versionString=$(PGO_VERSION)"' $(\
) --trimpath -o bin/postgres-operator ./cmd/postgres-operator

Expand Down
3 changes: 2 additions & 1 deletion internal/feature/features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ const (
// Support automatically growing volumes
AutoGrowVolumes = "AutoGrowVolumes"

// Deprecated
BridgeIdentifiers = "BridgeIdentifiers"

// Support custom sidecars for PostgreSQL instance Pods
Expand All @@ -101,7 +102,7 @@ func NewGate() MutableGate {
AppendCustomQueries: {Default: false, PreRelease: featuregate.Alpha},
AutoCreateUserSchema: {Default: true, PreRelease: featuregate.Beta},
AutoGrowVolumes: {Default: false, PreRelease: featuregate.Alpha},
BridgeIdentifiers: {Default: false, PreRelease: featuregate.Alpha},
BridgeIdentifiers: {Default: false, PreRelease: featuregate.Deprecated},
InstanceSidecars: {Default: false, PreRelease: featuregate.Alpha},
PGBouncerSidecars: {Default: false, PreRelease: featuregate.Alpha},
PGUpgradeCPUConcurrency: {Default: false, PreRelease: featuregate.Alpha},
Expand Down
3 changes: 3 additions & 0 deletions internal/postgres/users.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
//
// SPDX-License-Identifier: Apache-2.0

// [pg_query.Parse] requires CGO to compile and call https://github.com/pganalyze/libpg_query
//go:build cgo

package postgres

import (
Expand Down