Add Disk Auto Grow for pgWAL volumes #4262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update test and refactor to support different volume types.
tjmoore4
force-pushed
the
pgwal-vol-autogrow
branch
from
20238cd to
df4f805
Compare
jmckulk
approved these changes
Sep 3, 2025
This update adds the ability to automatically grow pg_wal PVCs. The AutoGrowVolumes feature gate must be enabled and the relevant volumes must include a Limit value. Once enabled, this feature tracks the current disk utilization and, when utilization reaches 75%, the disk request is updated to 150% of the observed value. At this point and beyond, the requested value will be tracked by CPK. The volume request can grow up to the configured limit value. Note: This change now treats limit values as authoritative regardless of the feature gate setting. However, the implementation also now allows limits to be updated after being set. Issue: PGO-1428
Autogrow statuses for volumes that no longer exist are now cleared. This commit updates the underlying PostgresCluster used for testing to conform to the new behavior. The test previously used partially constructed objects that wouldn't exist in a real cluster.
tjmoore4
force-pushed
the
pgwal-vol-autogrow
branch
from
df4f805 to
6831c78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the new behavior (if this is a feature change)?
This update adds the ability to automatically grow pg_wal PVCs.
The AutoGrowVolumes feature gate must be enabled and the relevant
volumes must include a Limit value.
Once enabled, this feature tracks the current disk utilization and, when
utilization reaches 75%, the disk request is updated to 150% of the
observed value. At this point and beyond, the requested value will be
tracked by CPK.
The volume request can grow up to the configured limit value.
Note: This change now treats limit values as authoritative
regardless of the feature gate setting. However, the implementation
also now allows limits to be updated after being set.
Also, adds repo host volume tests to 'TestStoreDesiredRequest.'
This separate commit updates the tests and refactors to support different volume types.
Other Information:
Issue: PGO-1428