Allow AutoGrow Tuning #4267
Allow AutoGrow Tuning #4267
Conversation
jmckulk
force-pushed
the
jmckulk/autogrow-tuning
branch
from
9e2962e to
ccf0e06
Compare
There was a problem hiding this comment.
Should these fields be added to the v1 api?
There was a problem hiding this comment.
🤔 I think so? I am curious as to why v1beta1 has this change
if s.DataVolumeClaimSpec.AutoGrow != nil {
s.DataVolumeClaimSpec.AutoGrow.Default()
}
but v1 doesn't?
There was a problem hiding this comment.
Oh its probably a missed change. I'm a little unsure when this is necessary 🤔
| Name: naming.ContainerPGBackRestConfig, | ||
| Command: reloadCommand( | ||
| naming.ContainerPGBackRestConfig, | ||
| cluster.Spec.Backups.PGBackRest.Repos), |
There was a problem hiding this comment.
We use a similar reloadCommand for both instance and pgbackrest reloader sidecars. This change introduces new parameters to both functions but they unfortunately don't match. The instance accepts two VolumeClaimSpecWithAutoGrow but the pgbackrest pod accepts a list of pgbackrest repos.
Ideally we would pass the same types to each function because they are doing the same things 🤔
Open to thoughts here too
There was a problem hiding this comment.
Open to other thoughts about where this function should be 💭
jmckulk
force-pushed
the
jmckulk/autogrow-tuning
branch
2 times, most recently
from
b15053f to
ac13b9a
Compare
jmckulk
force-pushed
the
jmckulk/autogrow-tuning
branch
2 times, most recently
from
e82c0b6 to
dc0c5eb
Compare
- Add new fields for Autogrow that allow configuring usage trigger and maxGrow size. - Update pgdata, pgwal, and repo volume fields to use new types - Update tests to account for new fields - Update Sidecar bash logic to use new autogrow fields
jmckulk
force-pushed
the
jmckulk/autogrow-tuning
branch
from
dc0c5eb to
19d9042
Compare
| MaxGrow *resource.Quantity `json:"maxGrow,omitempty"` | ||
| } | ||
|
|
||
| func (spec *AutoGrowSpec) Default() { |
There was a problem hiding this comment.
I'll make a note to check on this later.
2 participants
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
What is the new behavior (if this is a feature change)?
Other Information: