Implement Company & Product with JWT Authentication and PostgreSQL In… #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegration with alembic
AbdullahCrypthon
suggested changes
Oct 14, 2025
| SECRET_KEY = "af3287c8391bb9f4f7a72feb3b85f72e1d5bd07cbf4fa4ad9497c78412923312" | ||
| ALGORITHM = "HS256" | ||
| ACCESS_TOKEN_EXPIRE_MINUTES = 30 | ||
| ACCESS_TOKEN_EXPIRE_MINUTES = 7 * 24 * 60 |
There was a problem hiding this comment.
dont need to define time like this just write minutes or seconds
app/services/company_service.py
Outdated
Comment on lines
18
to
23
| new_company = Company( | ||
| name=company_data.name, | ||
| location=company_data.location, | ||
| type=company_data.type, | ||
| user_id=user_id | ||
| ) |
There was a problem hiding this comment.
instead of doing this make sure this is already coming from request as an object just call the repository here in service and do database insertions there
There was a problem hiding this comment.
i fix this today
app/services/company_service.py
Outdated
| type=company_data.type, | ||
| user_id=user_id | ||
| ) | ||
| self.db.add(new_company) |
There was a problem hiding this comment.
do this in repository and dont use self with it
app/services/user_service.py
Outdated
| new_user = User(username=user.username, password=hashed_pw) | ||
| self.db.add(new_user) | ||
| self.db.commit() | ||
| self.db.refresh(new_user) |
There was a problem hiding this comment.
dont need to use db.refresh untill it is necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tegration with alembic