Skip to content

Conversation

@lpi-tn
Copy link
Collaborator

@lpi-tn lpi-tn commented Jun 24, 2025

This pull request introduces a new workflow step for collecting data from Pressbooks in the urlcollectors workflows. The changes include adding a new pressbooks step in the cron-workflow.yaml file and defining the corresponding collect-pressbooks template in the workflow-template.yaml file.

Additions to the urlcollectors workflows:

  • New Pressbooks step in cron-workflow.yaml:

    • Added a new step named pressbooks under the spec section, which references the collect-pressbooks template and includes an argument for the pb_app_id parameter. ([k8s/welearn-datastack/templates/urlcollectors/cron-workflow.yamlR362-R371](https://github.com/CyberCRI/welearn-datastack/pull/49/files#diff-d1d02405646a6b92835c108eaecf74b73ec632084b87c8a063d585517d2da73bR362-R371))
  • Definition of collect-pressbooks template in workflow-template.yaml:

    • Added a new template named collect-pressbooks with synchronization settings, input parameters, and container configuration.
    • The container runs a Python module (welearn_datastack.nodes_workflow.URLCollectors.node_press_books_collect) and uses environment variables, volume mounts, and Azure file share integration for its operation. ([k8s/welearn-datastack/templates/urlcollectors/workflow-template.yamlR389-R429](https://github.com/CyberCRI/welearn-datastack/pull/49/files#diff-8f555b73600a29f609d3cf02f30db402d526e2ead1c54c22c0dd9bb5137672faR389-R429))

@lpi-tn lpi-tn requested a review from Nastaliss June 24, 2025 09:52
Copy link
Contributor

@Nastaliss Nastaliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lpi-tn lpi-tn merged commit dd81c66 into main Jun 24, 2025
6 checks passed
@lpi-tn lpi-tn deleted the Feature/pressbooks-workflow branch June 24, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants