This repository was archived by the owner on Apr 6, 2019. It is now read-only.
fixed zadd to take multimap instead of map #107
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Actually, this pull request will not be compatible with former version as it removed |
Owner
|
Hi, Thanks a lot for your PR, it sounds good! A new version will be released soon and will be a major one with breaking changes. Best :) |
Cylix
added a commit
that referenced
this pull request
Sep 20, 2017
Owner
|
Fixed in #108 (should be merged soon and released under 4.0.0). Best :) |
Cylix
added a commit
that referenced
this pull request
Sep 20, 2017
* Added sentiel and high availability(HA) versions of client and subscriber which will handle connect/reconnection automatically to redis server. * Merged changes * clang format * bump tacopie * unix compilation. will need some time to code review and port windows changes to unix. * clean unecessary changes. merge future_client into redis_client to make interface cleaner. rename redis_ prefix to classes * merge ha_client into client, refactore architecture. * merge ha_subscriber into subscriber * try_commit instead of commit in disconnection flow * doxygen * tacopie link & documentation & compilation fix * fix reconnection process * fix unit tests * clean code sentinel & make it consistent (avoid regression for example with callbacks execution) * ability to change number of io service workers at runtime * ha redis client example * doxygen doc * switch ZADD score param from map to multimap #107 * update CHANGELOG.md for 4.0.0 release * bump tacopie
Cylix
added a commit
that referenced
this pull request
Sep 21, 2017
* High availability, sentinel, design improvement (#101) * Added sentiel and high availability(HA) versions of client and subscriber which will handle connect/reconnection automatically to redis server. * Merged changes * clang format * bump tacopie * unix compilation. will need some time to code review and port windows changes to unix. * clean unecessary changes. merge future_client into redis_client to make interface cleaner. rename redis_ prefix to classes * merge ha_client into client, refactore architecture. * merge ha_subscriber into subscriber * try_commit instead of commit in disconnection flow * doxygen * tacopie link & documentation & compilation fix * fix reconnection process * fix unit tests * clean code sentinel & make it consistent (avoid regression for example with callbacks execution) * ability to change number of io service workers at runtime * ha redis client example * doxygen doc * switch ZADD score param from map to multimap #107 * update CHANGELOG.md for 4.0.0 release * bump tacopie * [4.0.0] update README
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I installed cpp_redis and was doing some tests. I used
zaddto make rankings of mine.I have some data that has same score.
But in
zaddofcpp_redis, it takesstd::map<score, member>as an argument.It seemed impossible to zadd data with same score in single command as the key of
std::mapis score.Of course I can query several
zaddcommands for each data, but I think it would be more convenient and effiecient to queryzaddmany data in single command.Therefore, I thought taking parameter as
std::multimapwould be better than taking them asstd::map.